Sorry to wake up this old thread. I'm looking at the javadoc of ByteToMessageDecoder and I'm not seeing any line saying - "don't release the ByteBuf your selfs". Am I missing something?
On Monday, June 30, 2014 at 11:45:15 AM UTC+3, Norman Maurer wrote: > > Hi Kevin, > > yeah the *Decoder and *Encoder classes call release by themselves as this > is what most users need. This is also stated in the javadocs there :) > > -- > Norman Maurer > [email protected] <javascript:> > > JBoss, by Red Hat > > > Am 30. Juni 2014 bei 09:58:24, Kevin Visscher ([email protected] > <javascript:>) schrieb: > > That's awesome :). > > I seem to have a small problem now that I'm calling release in my > ByteToMessageDecoder (releasing to often). Am I not required to call > release on the incoming buffer in a ByteToMessageDecoder? Because I saw in > the source code that the data and cumulation buffers are released? > > > On Monday, June 30, 2014 8:24:58 AM UTC+2, nmaurer wrote: >> >> The code should be exactly the same and work with both :) >> >> -- >> Norman Maurer >> [email protected] >> >> JBoss, by Red Hat >> >> >> Am 30. Juni 2014 bei 08:24:33, Kevin Visscher ([email protected]) >> schrieb: >> >> Hi Norman, >> >> Thanks for the reply. The article made it clear :). >> >> I have another question though, what if I would change my implementation >> to work with the pooled buffers. So I will be calling release on them >> afterwards. I now decide to switch back to unpooled buffers, does this mean >> I have to remove calls to release again? Or this there something hidden in >> Netty that allows me to keep my code base that works with the pooled >> buffers? >> >> On Monday, June 30, 2014 6:53:29 AM UTC+2, nmaurer wrote: >>> >>> Hey Kevin, >>> >>> yes the PooledByteBufAllocator is production-ready and will be the >>> default allocator from 4.1.0 on. >>> >>> Regarding the release of ByteBufs read: >>> http://netty.io/wiki/reference-counted-objects.html#wiki-h2-7 >>> >>> Hope it helps! >>> >>> -- >>> Norman Maurer >>> [email protected] >>> >>> JBoss, by Red Hat >>> >>> >>> Am 29. Juni 2014 bei 08:30:07, Kevin Visscher ([email protected]) >>> schrieb: >>> >>> Hello, >>> >>> I have a question regarding the PooledByteBufAllocator in Netty 4.20. Is >>> it stable enough to use in a production environment? And am I responsible >>> for releasing the buffers? Or does Netty handle that part when the buffers >>> are flushed or used for incoming messages in my ByteToMessageDecoder? >>> >>> Kinds regards, >>> Kevin >>> -- >>> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Netty discussions" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "Netty discussions" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> >> -- > > --- > You received this message because you are subscribed to the Google Groups > "Netty discussions" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > For more options, visit https://groups.google.com/d/optout. > > -- You received this message because you are subscribed to the Google Groups "Netty discussions" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/netty/0b560ba9-ac77-4655-a656-c85c4553d1c3%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
