Here are my comments so far: usr/src/cmd/cmd-inet/sbin/dhcpagent/agent.c
905: I pity the person who decides to invent a new sockaddr family and has routing sockets pass such a sockaddr up through a routing socket message. He will have his work cut-out for him. usr/src/cmd/cmd-inet/sbin/dhcpagent/interface.c 194, 803: Not that this matters, but SIOCGIFINDEX and the struct ifreq structure are obsolete. usr/src/cmd/cmd-inet/usr.lib/in.ndpd/main.c 552, 559: When temporary addresses are enabled, regular old addresses based on normal interface id's are also still in use. Won't deleting the prefix when temporary addressing fails result in all addresses being removed, and not just those that are temporary? Maybe I'm just misremembering how temporary addresses interact with stateless addrconf prefixes... 576: Why do you clear PR_AUTO here? usr/src/cmd/cmd-inet/usr.lib/in.ndpd/tables.c 234: s/flag is set to IFF_NOLOCAL/IFF_NOLOCAL flag is set/ But really, what does IFF_NOLOCAL mean now for a link-local address? I think it's only used now by in.ndpd when it gets an on-link prefix that is not to be used for stateless address autoconfiguration. usr/src/uts/common/inet/ip/ip.c 3421: When is arp ever used on an IPIF_POINTOPOINT interface, and why does this test matter here? usr/src/uts/common/inet/ip/ip_if.c 10609: The day is soon coming when this nonsense will be replaced with a nice looking MAC-Type check. :-) I have ip_ndp.c left to review, and I'm doing that today. Sorry for the delay. -Seb _______________________________________________ networking-discuss mailing list [email protected]
