Thank you for taking the time to review the changes. Please see response
below.
Dan Groves wrote:
If you have access to the SWAN, webrevs are located at:
http://zhadum.east.sun.com/export/ws/ss150715/clearview-libdlpi-port-onnv/webrev/
I haven't looked at anyone else's responses, so I don't know if anyone
already commented on these:
usr/src/cmd/cmd-inet/usr.sbin/in.rarpd.c:
lines 532-534: Is it intentional to have the loop keep going even if
dlpi_recv returns something other than DLPI_SUCCESS? In the original
code, if getmsg fails, syserr gets called. I don't see an equivalent
in the new code. Did I miss something?
Looking at this part of the code again this may be something I missed.
I changed the new code to continue if dlpi_recv returned something other
than DLPI_SUCCESS, with the error case DLPI_ETIMEDOUT in mind, in which
case we would like to continue. But if DL_SYSERR is returned, I think
syserr() needs to be called.
I'll make that change.
Thanks,
-Sagun
_______________________________________________
networking-discuss mailing list
[email protected]
