Wow! On Mon, Jul 16, 2007 at 02:32:05PM -0400, Peter Memishian wrote:
<SNIP!> > Thirumalai has already agreed to look at these changes (thanks, Thiru!), > but I'd like at least one additional reviewer. The changes are at: > > http://cr.opensolaris.org/~meem/ipmp-testaddr/ > > The only file that needs review is ip_if.c. (The in.mpathd-related > changes have already been reviewed -- and yes, they're independent of the > IP changes but ended up here for testing convenience.) This was a good job of refactoring. The new code is less complicated, and I'd suggest to every other reviewer out there to NOT use the sdiffs view if you can help it, because half of the reason this reply took so long was because I was using sdiffs where I probably shouldn't have. I only had one nit. We talked about it here in person, but I'm going to share it - and your reply - with the list. I noticed the hardwire constant "12" for the number of IRE pointers. It turns out that "12" is scattered throughout other parts of the code, and you were on record as saying this was a refactoring exercise, not an expedtion to fix additional brokenness. Thanks! Dan _______________________________________________ networking-discuss mailing list [email protected]
