> > http://cr.opensolaris.org/~meem/ipmp-testaddr/ > > > > The only file that needs review is ip_if.c. (The in.mpathd-related > > changes have already been reviewed -- and yes, they're independent of the > > IP changes but ended up here for testing convenience.) > > This was a good job of refactoring. The new code is less complicated, and > I'd suggest to every other reviewer out there to NOT use the sdiffs view if > you can help it
Indeed, sorry, I should've pointed that out. > I only had one nit. We talked about it here in person, but I'm going to > share it - and your reply - with the list. > > I noticed the hardwire constant "12" for the number of IRE pointers. It > turns out that "12" is scattered throughout other parts of the code, and you > were on record as saying this was a refactoring exercise, not an expedtion to > fix additional brokenness. Right. I've added the following comment: * Note: The upper bound of 12 IREs comes from the worst case of replacing * all six pairs (loopback and non-loopback) of broadcast IREs (all-zeroes, * all-ones, subnet-zeroes, subnet-ones, net-zeroes, and net-ones). Many thanks for the review. -- meem _______________________________________________ networking-discuss mailing list [email protected]
