On Thu, 2007-08-23 at 11:45 -0700, Erik Nordmark wrote:
> The CGTP (Carrier Grade Transport Protocol) support in IP needs to be
> extended to allow separate configuration of CGTP for different
> exclusive-IP zones.
>
> This is:
> PSARC 2007/250 CGTP for IP Instances
> 6572777 Need CGTP hooks version 3 to allow per-IP instance hooks
>
> The webrev is at:
> http://cr.grommit.com/~nordmark/cgtpv3/
>
> Who can code review this for me?
ip.c:28759 This should probably be bugged up in bugster. Are there
different levels of policy for configuring different stack instances?
ip.c: 28766 You removed the versioning checks on the ops. Why? (Ah,
now I see it, you have a redundant check in ip_cgtp_filter_register...)
ip_if.c:7281 I'd prefer to see to each side of a boolean && enclosed
with parens when it the test is compound (i.e. use " if ((x != NULL)
&& ... " instead of " if (x != NULL &&"
(Yes, I know its stylistic nic, but it avoids having to think about
operator predence. :-)
I'm not a CGTP guru, but the rest of it looks reasonable to me.
-- Garrett
>
> Thanks,
> Erik
>
>
> _______________________________________________
> networking-discuss mailing list
> [email protected]
_______________________________________________
networking-discuss mailing list
[email protected]
