Hi Eric, I read the code as a learning experience. :-) I have a question about your code about ASSERT:
ip.c: 28821 ipst = ns->netstack_ip; 28822 ASSERT(ipst != NULL); 28823 28824 ipst->ips_ip_cgtp_filter_ops = ops; We know the ASSERT will take effect on debug version only. And it do nothing on release version(Am I right?). The question is, it seems that ipst is possible to be a NULL for you are using the ASSERT to check it. How about on release version? Can we say it will panic here? Thanks, Jason Erik Nordmark 写道: > The CGTP (Carrier Grade Transport Protocol) support in IP needs to be > extended to allow separate configuration of CGTP for different > exclusive-IP zones. > > This is: > PSARC 2007/250 CGTP for IP Instances > 6572777 Need CGTP hooks version 3 to allow per-IP instance hooks > > The webrev is at: > http://cr.grommit.com/~nordmark/cgtpv3/ > > Who can code review this for me? > > Thanks, > Erik > > > _______________________________________________ > networking-discuss mailing list > [email protected] > _______________________________________________ networking-discuss mailing list [email protected]
