On Fri, Nov 07, 2008 at 10:05:59AM -0800, Gordon Ross wrote:
> This change lets the bge work on the NIC found in the Dell Precision M6300
> laptop.
> You are invited to review these changes:
> http://cr.opensolaris.org/~gwr/bge-5756/
bge_chip2.c does not appear to be consistent about comments like:
2056 + /*
2057 + * Apart from the label, we treat this as a 5755.
2058 + */
In some places it says:
2094 2116 /*
2095 2117 * Apart from the label, we treat this as a 5705(?)
2096 2118 */
and it others there's no comment whatsoever. The 5756 def you're adding
looks just like 5755 and 5787, and probably others, but there's no
comment for either 5755 nor 5787.
Anyone can see which chips are similar and which are not.
My conclusion: the comment lines you added at 2056-2058 are not needed.
And the existing comments like the one at 2116-2118 seem rather useless.
The only useful thing about them is the question mark, which indicates
that whoever added those wasn't sure that what they did was entirely
correct.
Nico
--
_______________________________________________
networking-discuss mailing list
[email protected]
