Nils, Sorry for the delay. I think your fix looks reasonable and I understand the case you're looking to solve.
> > Unfortunately, I don't know enough about the code you're changing to > > know if there might be other issues related to this change. (I think > > meem or perhaps Dave Miner would know better.) > > I would very much appreciate if someone else would review the changes. I took a look. It's been a while since I've been in this code, but I don't see a problem with them. > http://cr.opensolaris.org/~nigoroll/6667021_dhcpd_purge_own_offer/ A few nits: dhcp.c: * 696-697: combine into a single line. * 1879: Not sure what's meant by "by lists of so" interfaces.h: * 93: Remove argument name. general: * You're aware that adding copyrights is optional and that most opt not to, right? (It's your right if you want to have your copyright there, though persoanlly I'm not wild about having an ever-growing pile of names in each file.) -- meem _______________________________________________ networking-discuss mailing list [email protected]
