Hi Peter, > I took a look. It's been a while since I've been in this code, but I > don't see a problem with them.
Glad to hear. > > http://cr.opensolaris.org/~nigoroll/6667021_dhcpd_purge_own_offer/ > > A few nits: > > dhcp.c: > * 696-697: combine into a single line. Thanks. > * 1879: Not sure what's meant by "by lists of so" removed "so", thanks. > interfaces.h: > > * 93: Remove argument name. Ooops. Sorry. > general: > > * You're aware that adding copyrights is optional and that > most opt not to, right? (It's your right if you want to > have your copyright there, though persoanlly I'm not wild > about having an ever-growing pile of names in each file.) Hm. I have removed my copyright this time, but I think this is a fine line. My opionion is that there must be some motivation for OpenSolaris developers to contribute, and IMHO the opportunity to leave a trace can be a motivation. The updated webrev is http://cr.opensolaris.org/~nigoroll/6667021_dhcpd_purge_own_offer2/ Nils _______________________________________________ networking-discuss mailing list [email protected]
