Dan McDonald writes:
> As background, please consult the following webrev:
> 
>       http://cr.opensolaris.org/~danmcd/6777776/

This doesn't look right to me.  Your actually_send_keepalive()
function does a netstack_find_by_stackid(), but then fails to do
netstack_rele() -- the pointer returned by the former has a reference
held.  I think that's a reference leak.

Why not just do a netstack_hold() before launching the taskq, and
netstack_rele() when you're done?  Then you'll know that ipsec_out_ns
remains valid for the time required.

-- 
James Carlson, Solaris Networking              <[EMAIL PROTECTED]>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to