Jim,

- We already talked about having more common MAC hooks that would allow consumers like bridging and L2 filtering intercept and inject packets without having to change the common data-path. I'll start defining those soon.

- For the RX path you need to handle the poll path as well or you will miss packets, see mac_rx_srs_poll_ring(). I didn't see that covered in your design doc or code. mac_rx() covers the interrupt path only. BTW this is another example why generic MAC hooks would be useful to have, i.e. you wouldn't have to deal with all the details of the data-path.

- For the TX path we're going to modify the TX default processing to use a fanout of rings instead of a single default TX ring to better scale. So some of the changes you are making related to the TX entry points would have to be redone. It would be better to not have the callers specify the default TX ring.

Nicolas.

On Mar 18, 2009, at 3:05 PM, James Carlson wrote:

I'm inviting everyone involved with networking to review the design
document for Solaris Bridging.  The document is here:

 http://www.opensolaris.org/os/project/rbridges/bridging-design.pdf

The comment period begins today and ends next week, on the 25th of
March.  If you would like to offer comments but are unable to meet
that deadline, please let me know.  (Comments submitted after the
review period and without extension will be taken into account, but,
unless show-stopping, might be too late to adopt before the first
release.)

Note that this does *not* include the TRILL portion of the project.
That will be described and reviewed later.

Please submit comments on this list or to me personally.  Also, feel
free to forward this request to any other list where there may be
folks interested in reading and/or commenting on the design.  At the
end of the review period, I'll post summaries here of all of the
comments received and the answers to any issues noted.

Some reference materials you may want (but that are not under review
here):

 Project web page:
        http://www.opensolaris.org/os/project/rbridges/

 PSARC case:
        http://cr.opensolaris.org/~carlsonj/caselog/2008/055/

 Webrev versus ON (roughly build 111):
        http://cr.opensolaris.org/~carlsonj/webrev-rbridges-2009-03-18/

 Mercurial gate:
        ssh://[email protected]/hg/rbridges/rbridges-on

 SWAN-resident copy of the gate with cscope:
        /net/zhadum.east/export/zbuild/carlsonj/rbridges-snapshot/

--
James Carlson, Solaris Networking <[email protected] > Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________
networking-discuss mailing list
[email protected]

--
Nicolas Droux - Solaris Kernel Networking - Sun Microsystems, Inc.
[email protected] - http://blogs.sun.com/droux

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to