Looking through ip.c for the refactor review, I found this gem;

5900 ip_net_mask(ipaddr_t addr)
5901 {
5902         uchar_t *up = (uchar_t *)&addr;
5903         ipaddr_t mask = 0;
5904         uchar_t *maskp = (uchar_t *)&mask;
5905 5906 #if defined(__i386) || defined(__amd64)
5907 #define TOTALLY_BRAIN_DAMAGED_C_COMPILER
5908 #endif
5909 #ifdef  TOTALLY_BRAIN_DAMAGED_C_COMPILER
5910         maskp[0] = maskp[1] = maskp[2] = maskp[3] = 0;
5911 #endif


It predates the refactoring project so I'm reluctant to mention it here
but has anyone attempted to confirm if the above is still requried?

It looks like a workaround for an optimisation bug?

Darren

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to