On Thu, 2008-07-17 at 04:36 +0200, Michael Biebl wrote: > Roy Marples wrote: > > On Tue, 15 Jul 2008 15:29:43 +0100, Roy Marples <[EMAIL PROTECTED]> wrote: > >> Please apply this to NetworkManager :) > > > > I don't quite like the configure bits yet. It forces you to have either > dhclient or dhcpd installed for a successful build. > > This effectively makes the dhcp client a build depenency. > This doesn't really matter for a (source-based) distro like gentoo, but > on other distros, where the packages are built in a separate build > environment this means, that you now have to install a dhcp client.
The current configure environment forced me to install ppp for the development headers. I neither use nor care about ppp, so the same argument could be applied there. The reason why it's a build time check is that it's a lot easier to check the clients work in a shell script than in C at runtime. 1) Only dhcpcd-4 works with NM - older versions will not 2) Only ISC dhclient works with NM - derived versions will not (OpenBSD and FreeBSD have their own trimmed down versions with POSIX command line and don't have all the options needed) > I'd say, if an absolute path is given (i.e. > --with-dhcp-client=/sbin/dhclient), simply take this path and do no > further checks. Imo it's safe to assume, if someone is using the > configure flag this way, he knows what he's doing. That's probably a safe assumption to make. Thanks Roy _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
