Roy Marples wrote:
On Fri, 2008-08-08 at 18:25 +0200, Michael Biebl wrote:Roy Marples wrote:+if ! test -f src/dhcp-manager/nm-dhcp-"${DHCP_CLIENT}".c; then + AC_MSG_ERROR([No backend for the DHCP client ${DHCP_CLIENT}]) +fiThis check fails for srcdir != builddir => "make distcheck" will fail.I'm no autoconf guru :) You can either fail during compile with --with-dhcp-client=/bin/true that nm-dhcp-true.c does not exist, or try and detect borkage at configure time. Can you suggest anything better?
We only support dhcpcd and dhclient atm. So instead of doing a file check, I'd simply check if DHCP_CLIENT has the value "dhclient" or "dhcpcd" and fail otherwise. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
_______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
