On Tue, Sep 30, 2008 at 11:19 AM, Pablo Martí <[EMAIL PROTECTED]> wrote: > I think that Network.NetworkMode's enum has some values that should be > changed to something more realistic. The devices I have around (Option > and Huawei mainly) won't emit an 'ANY' signal, neither a 'PREFER_2G', > ditto with 'PREFER_3G'. I propose to change it to: > > MM_MODEM_GSM_NETWORK_MODE_NO = 0 # NO SIGNAL > MM_MODEM_GSM_NETWORK_MODE_GPRS = 1 > MM_MODEM_GSM_NETWORK_MODE_EDGE = 2 > MM_MODEM_GSM_NETWORK_MODE_3G = 3 > MM_MODEM_GSM_NETWORK_MODE_HSDPA = 4 > MM_MODEM_GSM_NETWORK_MODE_HSUPA = 5 > MM_MODEM_GSM_NETWORK_MODE_HSPA = 6 > > If the last three members seem to much info they could be marged into > a "3G+" although I prefer granularity and exactness :)
No, but the argument type passed with the signal is not an integer, it's NM_MODEM_GSM_NETWORK_MODE. That is, the same type that is used for setting the network mode. And thus, that type needs all these values. There is also no need to add another type which is just like NETWORK_MODE, but doesn't include some of it's values. Tambet _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
