On Fri, 2009-10-30 at 11:04 +0100, Jirka Klimes wrote: > On Wednesday 28 October 2009 19:53:56 Dan Williams wrote: > > On Tue, 2009-10-27 at 12:58 +0100, Jirka Klimes wrote: > > > On Friday 23 October 2009 19:19:14 Dan Williams wrote: > > > > Anyone want to do a really simple patch? It would close some bugs and > > > > help out a lot: > > > > > > Hello Dan, > > > > > > I've done the patch. Please, review it. > > > > > > NetworkingEnabled and WirelessEnabled are read from config file. If not > > > present, the values are regarded as true; if case of mangled values (or > > > something), false is used. > > > On changing values in the applet, the keys are changed (created) > > > in the cofiguration file. > > > > Thanks! Looks good so far, but I can see the logic in Tony's comments > > below where we shouldn't really mix state and configuration. Not your > > fault but mine when I initially proposed the solution. So three things: > > > > 1) I think we should default to "on" for both network and wifi when we > > have an error reading the state file > > > > 2) I guess we should leave the config file bits alone and do > > an /etc/NetworkManager.state file instead? > > > > 3) I'd also consolidate the impl_manager_sleep() and > > manager_set_wireless_enabled() bits into one helper function (since they > > pretty much do the same thing) > > > > Care to respin the patch? > > > > Thanks! > > Dan > > > > Hello, > > so here is the patch with the changes incorporated.
Thanks, committed to master and stable with a few cleanups. Dan _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
