Harrie, I am -0 on committing this code as-is but +1 on the concept. I spent some time looking at the patch and it generally looks okay but there is too much to review and do a good job of it. I recommend you break this patch into a minimum of three seperate patches. Do a patch that just does the code moves from protocol.c to http_protocol.c (no function change and no new code other than what is required to accomodate the move), another patch that introduces the http_request_rec and http_conn_rec, then another patch the introduces the state_rec. Make sense? Bill
- Apache 2.0 for multi protocol usage Harrie Hazewinkel
- Re: Apache 2.0 for multi protocol usage Bill Stoddard
- Re: Apache 2.0 for multi protocol usage Harrie Hazewinkel
- Re: Apache 2.0 for multi protocol usage Greg Stein
- Re: Apache 2.0 for multi protocol usage rbb
- Re: Apache 2.0 for multi protocol ... Greg Stein
- Re: Apache 2.0 for multi proto... Harrie Hazewinkel
- Re: Apache 2.0 for multi p... Bill Stoddard
- Re: Apache 2.0 for multi proto... Harrie Hazewinkel
- Re: Apache 2.0 for multi p... Greg Stein
- Re: Apache 2.0 for multi p... Harrie Hazewinkel
- Re: Apache 2.0 for multi p... Greg Stein
