Bill Stoddard wrote:
> Harrie,
> I am -0 on committing this code as-is but +1 on the concept.
Cool that you like the concept.
> I spent some time
> looking at the code and in general it looks okay, but there is too much to
> review and do a good job of it.
>
> I recommend you break this patch into a minimum of three seperate patches. Do
> a patch that just does the code moves from protocol.c to http_protocol.c (no
> function change and no new code other than what is required to accomodate the
> move), another patch that introduces the http_request_rec and http_conn_rec,
> then another patch the introduces the state_rec. Make sense?
Makes sense. It is a huge patch and understand that breaking it up in
pieces would make acceptance easier. A problem could be that it is
almost an atomic step.
Harrie
