Hi Nils, Nils Goroll wrote: > > ... it is assumed that prev has been properly set whenever i > 1. I > fear that future changes could break this assumption. > > I would suggest to initialize prev in line 1777 of your CR to make > this a little more robust. > > prev = cmp = &cm_hd; Yes, I incorporated your suggestion the latest webrev. > > Other than that, I'm happy with your change now. I also want to state > again publicly that, in retrospect, I think I have not taken your > suggestions as constructively as I would have wanted to. I want to try > to be as objective as possible, and I think that in this case I failed > to do so. Your involvement and effort to improve the quality of OpenSolaris is greatly appreciated. I hope the community can attract more people like you.
Thanks, -Dai