Hi Tom, On Fri, Feb 13, 2009 at 10:51:58AM -0600, Tom Haynes wrote: > Marcel Telka wrote: >> The webrev is available at <http://cr.opensolaris.org/~aragorn/6672480/>. >> Please note it contains a lot of formatting fixes so as a starting point I >> recommend the real fix at >> <http://cr.opensolaris.org/~aragorn/6672480.realfix>. >> >> > > I would have preferred that the real fix also be a full webrev. It is > nice to be able to look at the full context.
Good idea. I'll do that in my next fix, I confess! :-) Anyway, I hope you could easily locate the real fix in full webrev, if needed. > > BTW - thanks for thinking of isolating the changes. You are welcome :-). > > Have you scanned for other instances of this cleanup code? Yes. I scanned for all occurences of nfs_free_mi() - the dangerous function - and I found nothing suspicious. There are only three instances: nfs_mount()/nfs3_mount() - our case nfsrootvp()/nfs3rootvp() - the case I am referring as an example of good usage nfs_freevfs()/nfs3_freevfs() - here the mi is related to vfs, not vnode > > In any event, I approve of the changes. Thank you! -- Marcel Telka Solaris RPE
