Hi Marcel, > > 2. What will happen when VOP_PATHCONF() will return 0 in l, resp. in val or > in pc_val? >
Not sure if I understand. 0 in 1? or 0 or 1? Can you please explain when val or pc_val will have 0 or 1 in them as per the semantics of VOP_PATHCONF for _PC_FILESIZEBITS? > > 3. This code is dangerous and/or confusing (assignment in if without a test): > > 234 if (error = VOP_PATHCONF(vp, _PC_FILESIZEBITS, &pc_val, > cr, > 235 NULL)) > 236 return (error); > > I know this is out of the scope of your fix, but I would like to see it fixed. Is this a correctness issue? or aesthetics? Can you give a specific example where this is an obvious issue? I personally do not prefer the construct above myself, it can be hard to read, but at the same time I am not inclined to changing code in NFS as above, this late in the game. -Piyush
