Tom Haynes wrote: > Pavel Filipensky wrote: > > Hi NFS community, > > > > this a code review request for fix which is contributed by Juergen Keil > > <jk at tools.de>. > > I am acting as a sponsor (more about sponsoring: > > http://opensolaris.org/os/community/on/crt/sponsor-tasks/). > > > > Webrev can be found here: http://cr.opensolaris.org/~pavelf/6317111 > > > > and contains fixes for: > > > > 6317111 newboot x86 diskless client refuses to use nfs vers3 for root > > filesystem > > 6350002 newboot: failed VFS_MOUNTROOT() panics with a useless error message > > 6350006 BAD TRAP panic, when using unknown nfs protocol version in fstype > > property > > > > > http://cr.opensolaris.org/~pavelf/6317111/usr/src/uts/common/fs/vfs.c.frames.html > > 4524 if (vsw == NULL) { > 4525 cmn_err(CE_CONT, "Cannot find %s filesystem\n", fstyp); > 4526 return (ENXIO); > 4527 } > > > The callers already expect to handle ENXIO?
Yes. This new return is added in rootconf(), and the only caller is vfs_mountroot(), which does handle any error by calling panic(): if (rootconf()) panic("vfs_mountroot: cannot mount root"); > ----- > > > 4546 else > 4547 cmn_err(CE_CONT, "?root on %s fstype %s\n", > 4548 rootfs.bo_name, fstyp); > > > What does "?root" mean? The message is always sent to the system log, but is only written to the console when the system has been booted in verbose mode. This message posted from opensolaris.org