>
>>
>>
>> 4546 else
>> 4547 cmn_err(CE_CONT, "?root on %s fstype %s\n",
>> 4548 rootfs.bo_name, fstyp);
>>
>>
>> What does "?root" mean?

Sparc does the same:   uts/common/os/swapgeneric.c, rootconf(void)


   else
      cmn_err(CE_CONT, "?root on %s fstype %s\n",
          rootfs.bo_name, rootfs.bo_fstype);



===============

I have got 3 more comments:

1) 
http://cr.opensolaris.org/~pavelf/6317111/usr/src/uts/i86pc/os/fakebop.c.frames.html

1104   * then we need to set "fstype" to "nfsdyn" so we mount

the comment should change "nfsdyn" to "nfs"


2) again, "nfsdyn" should be replaced via "nfs" in 
/usr/sadm/lib/wbem/config_tftp

59   echo "setprop fstype 'nfsdyn'" >> ${BOOTENVRC}

Since /usr/sadm/lib/wbem/config_tftp is part of closed consolidation 
(not in onnv), I will handle this separately.


3) Fix for 6350006 BAD TRAP panic, when using unknown nfs protocol 
version in fstype property

should address also sparc, uts/common/os/swapgeneric.c, function rootconf()

   RLOCK_VFSSW();
   vsw = vfs_getvfsswbyname(rootfs.bo_fstype);
   RUNLOCK_VFSSW();

should be changed to

   RLOCK_VFSSW();
   vsw = vfs_getvfsswbyname(rootfs.bo_fstype);
   RUNLOCK_VFSSW();
  if (vsw == NULL) {
    cmn_err(CE_CONT, "Cannot find %s filesystem\n", fstyp);
    return (ENXIO);
  }


======
Can we get 1 more review?

Thanks,
Pavel


Reply via email to