Hi Robert, On Wed, Oct 21, 2009 at 10:41:50AM -0500, Robert Gordon wrote: > It looks good!.
Thank you! > > I did notice the following however: > > usr/src/lib/libfsmgt/common/nfs_mntinfo.c and usr/src/cmd/fs.d/nfs/ > nfsstat/nfsstat.c don't use the MI4_* defines, which is okay since > (for example) MI4_GRPID and MI_GRPID have the same value. At a > minimum we should add a comment to nfs4_clnt.h that states the > "dependency" .. (around line 1039..) Hm. There are many other MI flags with same values, for example MI_HARD vs. MI4_HARD, MI_PRINTED vs. MI4_PRINTED, etc. In addition, the nfsstat command silently assumes that those values are equal. Please read usr/src/cmd/fs.d/nfs/nfsstat/nfsstat.c around line 1220. If we wound want to add some kind of comment describing this aspect it should be more general, not only related to MI_GRPID vs. MI4_GRPID. I believe (and I hope :-) this is out of the scope of the proposed fix. Thanks. -- Marcel Telka Solaris RPE
