Hi Rob, On 03/02/10 11:53 -0700, Robert Thurlow wrote: > Jan Kryl wrote: > > Hi, > > please could you review the following fix for 6920999? > > webrev: > > http://cr.opensolaris.org/~jkryl/nfs-utf8/ > > Hi Jan, > > The changes look good to me except for something related > to the ASSERT change Tom mentioned. I think ASSERTs and > a runtime check should be put in nfscmd_findmap(), which > is the highest point that is vulnerable to a stray NULL > pointer. > I have removed asserts and added a NULL-test in nfscmd_findmap() as you have suggested. I think that the asserts aren't usefull anymore now when we test NULL values for both debug and non-debug kernels.
> Thanks for running with this, I had not appreciated there > was incomplete implementation on the server as well. The > CR should be clear that this problem and this fix is about > the server side, not the client. > I have added a clear statement to evaluation of CR to clarify this. Please see new revision of webrev: http://cr.opensolaris.org/~jkryl/nfs-utf8-3/ Thanks for your comments -Jan
