Hi,
Frank Filz wrote on Fri, Apr 24, 2015 at 02:59:49PM -0700: > 3. Change our workflow to work with gerrithub better (stop using the > incremental patch process). One loss here would be the ability to bisect and > hone in on a small set of changes that caused a bug. I think this isn't the way to go, there's another way we can change our workflow - that is stop considering each "pull request branch" as some kind of unsplittable chunk. Let's take an example. This week you accepted two commits from Vincent then saw the third wouldn't work and stopped there. What's wrong with that? We can have him rework third commit onwards only and keep the two patches that were fine. We already require that each patch, individually, doesn't break anything. That's mandatory for bisectability, git has to be able to pick any commit anywhere and not break everything because a feature has been done in two unlogically split commits (e.g. a big commit isn't split by pushing one file at a time!) >From the moment each patch on its own is fine, then there's nothing wrong with pulling in stuff that's ok and stopping from the moment something looks fishy, processing to another "pull request" and waiting for the next week to fix things. Likewise, we (people pushing patches) also need to change how we work: patches that aren't related should not be kept in a chain when pushed, but all based directly on nfs-ganesha's tag and pushed one at a time, ready to be merged whatever the order. Only when the same piece of codes are changed in multiple commits then we should push in a branch, and only then Frank has to care about the order -- but that's not necessary for most commits. We already don't care if you get Marc's or Matt's branch first, we shouldn't care either if you get my commit A or my commit B first unless they're related either. More flexibility from everyone there should make the whole process alot easier, even if yes it's more work to push 5 individual branches than one branch with 5 commits. -- Dominique ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
