> > >> From what I can tell, Frank finds problematic > > > > > > 1) a lack in gerrit of a "changeset" concept, plus, apparently > > > > It actually exists and is called “topic”. It will be very soon > > possible as well to merge a whole topic atomically with one click. > > I found "topic" mentioned in some online discussion, but there seemed to be > mixed reviews from some developers. I didn't come away with a clear sense > of the strengths and weaknesses of the feature, but there appear to be > tradeoffs.
Being able to merge a whole topic with one click will really help us. > > It is actually in beta and will be released very soon: it is called > > “NoteDB”. It is basically the archive of all review history (including > > ratings and comments) as Git objects. > > This sounds interesting, but what I think Frank and Dominique were > specifically looking for is for the affirmative reviews in gerrit to be > transformed into "Acked-By" statements in the primary commit msg in git on > merge. > > Is that behavior part of NoteDB, or, alternately, something that we can > straightforwardly accomplish with gerrithub? With the gerrithub cherry pick merge form, we get reviewed-by and tested-by added to the patch. Apparently we could also add an Acked-by label. I will have a look at that, though I'd be happy with the reviewed-by and tested-by annotations in the commit message. In fact, adding an acked-by might add additional churn to the review process. Frank ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
