Summarizing from call.

Presumably we'd normally fix this without taking larger reorganization
changes from duplex-12, but IIRC, there's a larger list of things, and we 
agreed to
bring a list to the next call for discussion.

Matt

----- "William Allen Simpson" <william.allen.simp...@gmail.com> wrote:

> On 6/24/15 1:24 PM, Malahal Naineni wrote:
> >>    /* cleanup thread context */
> >>    destroy_wait_entry(&thrd->ctx.we);
> >> -  --(thrd->pool->n_threads);
> >>    mutex_lock(&pool->we.mtx);
> >> +  --(thrd->pool->n_threads);
> >>    cond_signal(&pool->we.cv);
> >>    mutex_unlock(&pool->we.mtx);
> >>    mem_free(thrd, 0);
> >> --
> My solution in duplex-12 was:
> 
>       /* cleanup thread context */
> -     destroy_wait_entry(&thrd->ctx.we);
> -     --(thrd->pool->n_threads);
> -     mutex_lock(&pool->we.mtx);
> -     cond_signal(&pool->we.cv);
> -     mutex_unlock(&pool->we.mtx);
> -     mem_free(thrd, 0);
> +     atomic_dec_uint32_t(&pool->n_threads);
> +     cond_destroy(&wpt->pqcond);
> +     mem_free(wpt, sizeof(*wpt));

-- 
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://cohortfs.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to