As I understand it, various max values will be in use, depending on the
structure being decoded. The original ~0 probably should have been a constant.
Matt
----- Original Message -----
> From: "William Allen Simpson" <william.allen.simp...@gmail.com>
> To: nfs-ganesha-devel@lists.sourceforge.net
> Sent: Tuesday, March 1, 2016 9:00:14 AM
> Subject: Re: [Nfs-ganesha-devel] Unbounded memory allocations (based on
> client data)
>
> On 2/29/16 6:12 PM, Dominique Martinet wrote:
> > @@ -4070,7 +4069,7 @@ extern "C" {
> > return false;
> > if (!xdr_array
> > (xdrs, (char **)&objp->na41_aces.na41_aces_val,
> > - (u_int *) &objp->na41_aces.na41_aces_len, ~0,
> > + (u_int *) &objp->na41_aces.na41_aces_len, 1024,
> > sizeof(nfsace4), (xdrproc_t) xdr_nfsace4))
> > return false;
> > return true;
> >
> >
> > (I just need more time to make a constant macro and fix line lengths
> > etc)
> >
> >
> > Productive first day!
> >
> Good catch, but please use a defined constant such as
> LIMIT_XDR_ARRAY so we can find these (or mass change).
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
--
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://www.redhat.com/en/technologies/storage
tel. 734-707-0660
fax. 734-769-8938
cel. 734-216-5309
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
