On 1/3/17 2:22 PM, GerritHub wrote: > Frank Filz *posted comments* on this change. > > View Change <https://review.gerrithub.io/307526> > > Patch Set 1: > > (1 comment) > > * > > File src/MainNFSD/nfs_rpc_dispatcher_thread.c: > <https://review.gerrithub.io/#/c/307526/1/src/MainNFSD/nfs_rpc_dispatcher_thread.c> > > o > > Patch Set #1, Line 66: > <https://review.gerrithub.io/#/c/307526/1/src/MainNFSD/nfs_rpc_dispatcher_thread.c@66> > |#define NFS_pcp nfs_param.core_param| > > Yes. On some lines (for example req->rq_prog was expanded to > req->rq_msg.cb > > Would nfs_core_param be short enough? > > There really isn't any reason to bundle all the different param > structures in a structure. If we > Agreed, but not a focus of this patch. It would be much more intrusive.
> #define nfs_core_param nfs_param.core_param > That would be nice. > We can fix the other references over time, and eventually unbundle > core_param from the structure. > Good idea. > We could also look at changing the name of any specific parameters > that have very long names... > nfs_param.core_param.core_options to just nfs_core_param.options. Anyway, outside the scope of this patch. This patch uses the standard #define technique for shortening that is widely used in ntirpc. For example, see the previous sentence in the commit message. Let's not endlessly thrash over which specific define to use today. That could be the topic of a future stand-alone patch. This one works now, as opposed to something better in the future. > To view, visit this change <https://review.gerrithub.io/307526>. To > unsubscribe, visit settings <https://review.gerrithub.io/settings>. > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
