On 1/4/17 1:35 PM, William Allen Simpson wrote: > On 1/3/17 2:22 PM, GerritHub wrote: >> Frank Filz *posted comments* on this change. >> >> Would nfs_core_param be short enough? >> >> There really isn't any reason to bundle all the different param >> structures in a structure. If we >> > Agreed, but not a focus of this patch. It would be much more intrusive. > Looking at this today, turns out there is some kind of reason to have 3 and 4 level structs. Mostly because GSS is conditionally compiled.
It's in gsh_config.h -- blame Adam Emerson. > >> #define nfs_core_param nfs_param.core_param >> > That would be nice. > Nope, already in use in typedef struct nfs_core_param. > This one works now, as opposed to something better in the future. > Yep, my shorter contractions are a better long-term fit for this code. They are clearer (defines having leading UPPER CASE), with fewer conflicts. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
