On 02/15/2017 07:46 AM, Satya Prakash GS wrote: > Frank, > > I have subscribed to the list. Apologies for any inconvenience caused. > >> This wouldn't actually help since the call to test_access just winds up in >> fsal_test_access which isn't going to know about your special super user. >> All Ganesha is doing here is not making a test_access call that turns into >> an fsal_test_access call that would always fail the permission check - or >> actually, I think it might always pass the permission check for files that >> don't have an NFS v4 ACL... We would have to change the test_access API to >> add permissions to check for in mode tests that are outside the mode >> permission checking... > >> The alternative as a general mechanism is to increase the number of calls to >> the underlying filesystem Ganesha makes which is likely to have a negative >> impact on other FSAL's performance. > > Our filesystem doesn't support NFSv4 ACLs. Sorry to prolong this > further but just to be clear, we have implemented our own test_access > call. In our test_access implementation we have a way to figure out if > the user is super user or not. Agree that removing the check would > result in a lot of fsal_test_access calls.
MDCACHE doesn't call into the FSAL for test_access(), it calls directly into fsal_test_access(), so your test_access() won't get called at this point. The reason for this was to use cached attributes, saving a getattr() on every test_access(), which was a visible (~20%) degradation small file read/write. So, as it currently stands, this won't work. See the comment in mdcache_test_access() for more info. This can be fixed, but has not been so far, because no in-tree FSAL does anything other than call fsal_test_access(). Daniel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
