Dan, I think your code should work except that you call
create_handle(fh_desc) after calling extract_handle(fh_desc) in
mdcache_locate_wire(). I think making a copy here would preserve the wire
handle before passing to create_handle. Samething
with nfs3_FhandleToCache(), I believe.
GPFS currently assumes that create_handle() really gets host-handle (not
just GPFS, everyone else as well as it lacks flags parameter prior to your
patch), NOT wire handle. That is easy to change, but I wonder if we really
need endian conversion in extract_handle as well as create handle. So I
added handle_to_key export operation to get the key and extract_handle only
extracts the handle, not the key.
Here are couple commits, the second one is really a clean up. I just
compiled, and haven't done any testing at this point. I will test after
some comments!
https://review.gerrithub.io/358746 Add handle_to_key export operation.
https://review.gerrithub.io/358747 Replace mdcache_key_t in struct fsdir by
host-handle
On Wed, Apr 26, 2017 at 8:30 PM, Daniel Gryniewicz <d...@redhat.com> wrote:
> Hi, Malahal.
>
> Since we discussed wire handle / key issues on the call, I went and took
> a look, and it seems I screwed it up when I did the MDCACHE conversion.
> I was calling extract_handle() before calling create_handle(),
> effectively removing wire handles for the system.
>
> I believe that the set of API functions we have is sufficient, and so
> I've fixed the usage. I've put up a PR here:
> https://review.gerrithub.io/358710
>
> Could you take a look at the way it is now, and see if it works for GPFS?
>
> Thanks,
> Daniel
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
