> A user of the FSAL_PROXY recently opened an issue on github about the fact > that FSAL_PROXY clears request_mask when pxy_getattrs is called what is > actually true and produces useless re-retrieval of attributes in MDCACHE. > > > First, could anybody definitely confirm that any FSAL must not modify > request_mask ? > > > Second, I would like to understand why mdcache_refresh_attrs function of > FSAL_MDCACHE calls mdc_fixup_md(entry, &attrs) and not > mdc_fixup_md(entry, &(entry->attrs)). Indeed, every things seems to be > well done in mdcache_refresh_attrs and fsal_copy_attrs to preserve the > original request_mask in entry->attrs from a corruption from SubFSAL in > attrs except this call.
FSALs SHOULD NOT modify request_mask, however, on examination, I saw some pitfalls if an FSAL provides an updated ACL gratis, so I will be posting a patch to clean things up, which will incidentally fix the issue here because it will use &entry->attrs to get a preserved request_mask (that has been updated if the FSAL provided ACL gratis). Frank --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
