On Mon, Jan 15, 2018 at 09:45:52AM -0800, Frank Filz wrote: > Yes, we could move it into common code. I wish we had been able to > avoid having it in the first place since it’s an imperfect conversion, > but we have it so…
Moving it to common code seems like a good appraoch. > If we move it into common code, I would appreciate someone throwing a > fairly complete set of ACL tests against it and make sure all bugs are > out, or at least that our conversions match what is done by knfsd. Jiffin had quite a complete set of tests while he was working on the conversion. We should probably add these to the CI. > Is there any requirement for POSIX ACLs for NFS v3? Linux knfsd does > have a sideband protocol for POSIX ACLs for NFS v3 which we COULD > implement if there was demand for it. I have seen requests for supporting ACLs in the Gluster/NFS (v3 only) server. But those came at the time when NFSv4 was not much used yet. I think there is no large demand for NFSv3 + ACLs, most users will be able to use NFSv4 now. Niels > > > > Frank > > > > From: Sriram Patil [mailto:srir...@vmware.com] > Sent: Monday, January 15, 2018 3:32 AM > To: nfs-ganesha-devel@lists.sourceforge.net > Cc: Kamal Charan <kcha...@vmware.com>; Sakthi Kumar <sakt...@vmware.com> > Subject: [Nfs-ganesha-devel] [GlusterFS] NFsv4 to POSIX ACL conversion > > > > Hi, > > > > I see that there is NFSv4 ACLs to POSIX ACLs mapping code written in > GlusterFS FSAL. Since, this is pretty standard code and other FSAls may use > it instead of duplicating the same code every time, can we move the ACL > conversion code to a common place in Ganesha? The code is independent of the > other GlusterFS code. > > > > Let me know your thoughts. > > > > Thanks, > > Sriram > > > > --- > This email has been checked for viruses by Avast antivirus software. > https://www.avast.com/antivirus > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Nfs-ganesha-devel mailing list > Nfs-ganesha-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
