On Wed, 2018-02-21 at 16:22 -0500, William Allen Simpson wrote: > On 2/21/18 1:59 PM, GerritHub wrote: > > Jeff Layton has uploaded this change for *review*. > > > > View Change <https://review.gerrithub.io/400871> > > > > MainNFSD: invert _NO_PORTMAPPER option > > > > The fact that this is a "negative" option is confusing. Change it > > to a "PORTMAPPER" option, and have it default to ON. > > > > While I vaguely agree with the former in principle, in this day and age > we really should stop using the name PORTMAPPER. Replaced by rpcbind a > long time ago, and shouldn't be shipping with modern systems. > > In ntirpc, PORTMAP is as expected the old version 2 UDP-only call. We > should kill it. > > We really shouldn't encourage folks to use a UDP system that has long > had known DDoS attacks. > > And we really should be migrating from NFS 2 UDP to NFS 3 TCP, as a > minimum supported version.... > > Also, we have talked about adding rpcbind itself to Ganesha or ntirpc.
FWIW, my main interest is in being able to just remove this support wholesale for v4.x-only configs. NFSv4 does not require any rpcbind registration. I don't feel too strongly about the naming, and I doubt this would encourage anyone to go use the ancient portmapper code. I can rename it if you like, but this seems like bikeshedding. Note that the rpm specfile has the ability to build ganesha for really old distros (pre-RHEL6). If you feel strongly about this then we should remove that support as well. -- Jeff Layton <jlay...@redhat.com> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
