Thanks, that's much easier! And does not require changes to QueryLoader. I have made a micropatch which adds a property name to documentid mapping (with default = RootClass.DefaultIdentifierColumnName). Also it fixes the messages in SearchMappingFactory which have overlooked copy/paste errors.
Attached to this message. On Sun, Oct 18, 2009 at 4:14 PM, Ayende Rahien <[email protected]> wrote: > Andrey, > In the mapping, then, you have to specify "id" as the property name, and > let NH figure the rest for itself. > > > On Sun, Oct 18, 2009 at 2:09 PM, Andrey Shchekin (ashmind) < > [email protected]> wrote: > >> >> Since the only previous mapping was attribute-based, class always had >> [DocumentId] set on some property => this property had to exist. >> >> Now, I do not use any kind of primary keys in domain model, only in >> DB. But I still want to use this key in mapping. >> So I create a DocumentId, but the class does not have a property with >> corresponding name => QueryLoader crashes. >> (btw I just understood that I have broken a previously working use >> case with documentid indexed name != property name, but this is >> unrelated problem) >> >> On Oct 18, 4:01 pm, Ayende Rahien <[email protected]> wrote: >> > I am sorry, I am not following what the problem is >> > >> > On Sun, Oct 18, 2009 at 1:53 PM, Andrey Shchekin (ashmind) < >> > >> > >> > >> > [email protected]> wrote: >> > >> > > One (now known) issue with the current patch: without attributes, it >> > > is possible to map DocumentId to a DB-only Id. >> > > In that case, there is an issue described here >> > >> > >http://stackoverflow.com/questions/1583520/nhibernate-a-correct-way-t. >> .. >> > >> > > I haven't included fix into the current patch because it covers the >> > > use case that wasn't possible before, and currently I fixed it for Id >> > > only. >> > > Needs a solution for both cases (Id/not Id), simple, but haven't yet >> > > done. >> > >> > > On Oct 18, 3:32 pm, Ayende Rahien <[email protected]> wrote: >> > > > Applied, thanks. >> > > > We would be very happy to see another mapping strategy implemented >> :-) >> > >> > > > On Sun, Oct 18, 2009 at 10:25 AM, Andrey Shchekin (ashmind) < >> > >> > > > [email protected]> wrote: >> > >> > > > > Ayende, >> > >> > > > > That's strange, my version information currently is >> > > > > URL: >> > > > > >> https://nhcontrib.svn.sourceforge.net/svnroot/nhcontrib/trunk/src/NHi. >> > > .. >> > > > > Revision/Author< >> > > >> https://nhcontrib.svn.sourceforge.net/svnroot/nhcontrib/trunk/src/NHi.. >> .>: >> > > > > 1049 ayenderahien >> > > > > Last commit revision: 1045 >> > > > > Is it a wrong version? >> > >> > > > > I re-generated and added to the issue ( >> http://nhjira.koah.net/secure/ >> > > > > attachment/12956/ashmind-NHibernate.Search-ISearchMapping.patch< >> > > >> http://nhjira.koah.net/secure/%0Aattachment/12956/ashmind-NHibernate....> >> > > > > ) >> > > > > Sorry for the same name. >> > >> > > > > But according to file comparer it is not really different from the >> > > > > original patch (except some small stuff I added since). >> > >> > > > > On Oct 18, 4:19 am, Ayende Rahien <[email protected]> wrote: >> > > > > > Andrey, >> > > > > > I tried to apply the patch, but it seems to be against an old >> version >> > > of >> > > > > NH >> > > > > > Search, and there are a LOT of conlicts. >> > > > > > Can you regenerate the patch against the trunk? >> > >> > > > > > On Thu, Oct 15, 2009 at 1:57 PM, Andrey Shchekin (ashmind) < >> > >> > > > > > [email protected]> wrote: >> > >> > > > > > > Hello everyone, >> > >> > > > > > > I have created a patch that implements the abstraction of >> mapping >> > > > > > > strategy for NHibernate.Search. >> > > > > > > Now it is not limited to attributes. >> > >> > > > > > > What is the review process and when it can get integrated if >> > > > > > > everything is ok? >> > > > > > > Seeing some previous post in this group I started by creating >> a >> > > JIRA >> > > > > > > issue: >> > > > > > >http://nhjira.koah.net/browse/NHSR-24 >> > >> > > > > > > But I am still interested in what is the integration estimate, >> > > because >> > > > > > > the changes are somewhat significant and later integration can >> lead >> > > to >> > > > > > > a merging problems. >> > >> > > > > > > Andrey Shchekin >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "NHibernate Contrib - Development Group" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com.ar/group/nhcdevs?hl=en -~----------~----~----~----~------~----~------~--~---
ashmind-ISearchMapping-DocumentId.patch
Description: Binary data
