So overall it is all goodies? On Sun, Oct 18, 2009 at 11:44 PM, Andrey Shchekin <[email protected]> wrote:
> I think it is the other way -- NHibernate.Validator and codegen tools could > *also* benefit from an extensible schema. > > > On Mon, Oct 19, 2009 at 1:35 AM, mathieu <[email protected]> wrote: > >> >> What about NHibernate.Validator like mappings ? >> >> On 18 oct, 23:19, Andrey Shchekin <[email protected]> wrote: >> > There is also some kind of "meta-attributes", but they are really >> ugly.My >> > opinion is that right approach is to fix the schema and NH loader (so it >> > adds additional attributes to the loaded schema, as it does with >> > MetaAttributes). >> > >> > I have no idea on hard it is (schema -- trivial, deserialization -- ?), >> but >> > I think it is just the right thing to do. >> > >> > On Mon, Oct 19, 2009 at 1:11 AM, mathieu <[email protected]> >> wrote: >> > >> > > I tried this, had validation errors, asked this question on >> > > stackoverflow (here : >> > >http://stackoverflow.com/questions/1585959/extend-an-xml-schema >> > > ) and came to this conclusion : >> > > To do that, you would have to modify the existing nhibernate- >> > > mapping.xsd, don't you ? >> > >> > > So, what about an "other" mapping file, alongside the .hbm.xml >> > > (something in the likes of .hsbm.xml) ? >> > >> > > On 18 oct, 13:42, "Andrey Shchekin (ashmind)" <[email protected]> >> > > wrote: >> > > > Well for my project right now I just did a very simple custom >> mapping. >> > > > I was considering <class name="MediaItem" table="MediaItems" >> > > > search:indexed="true", but not with the changelist I already had. >> > >> > > > Maybe later, if no one else does that. >> > >> > > > On Oct 18, 3:32 pm, Ayende Rahien <[email protected]> wrote: >> > >> > > > > Applied, thanks. >> > > > > We would be very happy to see another mapping strategy implemented >> :-) >> > >> > > > > On Sun, Oct 18, 2009 at 10:25 AM, Andrey Shchekin (ashmind) < >> > >> > > > > [email protected]> wrote: >> > >> > > > > > Ayende, >> > >> > > > > > That's strange, my version information currently is >> > > > > > URL: >> > >> > >https://nhcontrib.svn.sourceforge.net/svnroot/nhcontrib/trunk/src/NHi. >> .. >> > > > > > Revision/Author< >> > > >> https://nhcontrib.svn.sourceforge.net/svnroot/nhcontrib/trunk/src/NHi.. >> .>: >> > > > > > 1049 ayenderahien >> > > > > > Last commit revision: 1045 >> > > > > > Is it a wrong version? >> > >> > > > > > I re-generated and added to the issue ( >> > >http://nhjira.koah.net/secure/ >> > > > > > attachment/12956/ashmind-NHibernate.Search-ISearchMapping.patch< >> > > >> http://nhjira.koah.net/secure/%0Aattachment/12956/ashmind-NHibernate....> >> > > > > > ) >> > > > > > Sorry for the same name. >> > >> > > > > > But according to file comparer it is not really different from >> the >> > > > > > original patch (except some small stuff I added since). >> > >> > > > > > On Oct 18, 4:19 am, Ayende Rahien <[email protected]> wrote: >> > > > > > > Andrey, >> > > > > > > I tried to apply the patch, but it seems to be against an old >> > > version of >> > > > > > NH >> > > > > > > Search, and there are a LOT of conlicts. >> > > > > > > Can you regenerate the patch against the trunk? >> > >> > > > > > > On Thu, Oct 15, 2009 at 1:57 PM, Andrey Shchekin (ashmind) < >> > >> > > > > > > [email protected]> wrote: >> > >> > > > > > > > Hello everyone, >> > >> > > > > > > > I have created a patch that implements the abstraction of >> mapping >> > > > > > > > strategy for NHibernate.Search. >> > > > > > > > Now it is not limited to attributes. >> > >> > > > > > > > What is the review process and when it can get integrated if >> > > > > > > > everything is ok? >> > > > > > > > Seeing some previous post in this group I started by >> creating a >> > > JIRA >> > > > > > > > issue: >> > > > > > > >http://nhjira.koah.net/browse/NHSR-24 >> > >> > > > > > > > But I am still interested in what is the integration >> estimate, >> > > because >> > > > > > > > the changes are somewhat significant and later integration >> can >> > > lead to >> > > > > > > > a merging problems. >> > >> > > > > > > > Andrey Shchekin >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "NHibernate Contrib - Development Group" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com.ar/group/nhcdevs?hl=en -~----------~----~----~----~------~----~------~--~---
