yes, we can and should, since there is a disagreement here. I suggest doing this on the nhusers mailing list, since this would be a way to get input from the users themselves about this
On Thu, Apr 16, 2009 at 5:54 PM, Davy Brion <[email protected]> wrote: > not exactly a strong argument IMO > > can't we at least vote on this or something? > > On Thu, Apr 16, 2009 at 4:51 PM, Fabio Maulo <[email protected]> wrote: > >> In our team there are few occasions where I and Oren agree the same >> solution and when it happen can not be missed. >> >> 2009/4/16 Davy Brion <[email protected]> >> >>> i know why i write tests, but i have no idea why people in the past >>> didn't always do so... our tests simply won't catch everything >>> >>> personally, i think the safest choice should be the default... the new >>> parser should IMO become the default after the 2.1 release >>> >>> if this new parser turns out to cause problems in the 2.1 release which >>> could've been avoided by staying with the old parser, our users probably >>> won't have much trust left in the NH team and it won't be easy to win it >>> back either. >>> >>> >>> On Thu, Apr 16, 2009 at 4:33 PM, Fabio Maulo <[email protected]>wrote: >>> >>>> 2009/4/16 Davy Brion <[email protected]> >>>> >>>>> wait, are we really going to have the new AST parser as the default one >>>>> for the 2.1 release? We might have 1700 tests, but our test suite isn't >>>>> really all that great and having the new AST parser as the default at this >>>>> point would be a bit risky i think. >>>> >>>> >>>> If you are afraid you can configure NH to use the "Classic" >>>> queryTranslator (is only one line in the session-factory configuration). >>>> >>>> Now think about this: >>>> Why you are writing tests ? >>>> >>>> Don't be afraid Davy, trust in your self and in the NH's team. >>>> >>>> -- >>>> Fabio Maulo >>>> >>>> P.S. check the log of SVN to understand when 2.0 born and than check >>>> which is the most important issue fixed between 2.0.0 and 2.0.1 (note 2.0.1 >>>> has the record of NH downloads; today is 56412) >>>> >>> >>> >> >> >> -- >> Fabio Maulo >> > >
