That's it committed on both the 2.1.x branch and the trunk. From: Ayende Rahien Sent: Tuesday, September 15, 2009 10:13 PM To: [email protected] Subject: [nhibernate-development] Re: Thread Safety issue with NH 2.1.x
Yes, please add the test anyway. I'll review it when you have it there. On Wed, Sep 16, 2009 at 12:11 AM, Richard Brown (gmail) <[email protected]> wrote: I've got a patch to completely remove the AdjustNamedParameterLocationsForQueryParameters() introduced in r4158 to fix NH-1693. When I look over the function again I think I must have been having a 'thick day' when I wrote it. I suspect this will also fix the threading issue, but I cannot confirm this. I tried the threading test, and got it to fail once, but it's passed every time after that on my machine (probably some kind of threading/timing issue). I'll commit the change unless there's any objections. Should I add the test (that doesn't fail on my machine) anyway? From: Richard Brown (gmail) Sent: Thursday, September 10, 2009 7:56 PM To: nhibernate-development Subject: Re: [nhibernate-development] Re: Thread Safety issue with NH 2.1.x Is there an option d/ for making the ParameterTranslationImpl threadsafe? (If I/we could get rid of the call to AdjustNamedParameterLocationsForQueryParameters() would it be threadsafe again?) From: Ayende Rahien Sent: Thursday, September 10, 2009 6:58 PM To: nhibernate-development Subject: [nhibernate-development] Thread Safety issue with NH 2.1.x I am following on a bug report that I got, and I have confirmed that we have a thread safety issue within NHibernate. The conditions for that are quite esoteric, which is why no one got it so far. I attached a patch the expose the issue. This was introduced in r4679, to fix NH-1908.
