Thanks Patrick for the investigation. Probably those classes in Impl are now really unused and its missing remotion was my fault (r3057).
On Sun, Aug 1, 2010 at 3:08 PM, Patrick Earl <[email protected]> wrote: > It seems like batch_size leads to the following files: > > AdoNet/OracleDataClientBatchingBatcher.cs > AdoNet/SqlClientBatchingBatcher.cs > AdoNet/SqlClientSqlCommandSet.cs > > Strangely, the operations in those files seem to correspond exactly to > the operations in the other files I was referring to. For example > "add to batch", "count of commands in batch", etc. > > I don't see any usage of the Impl/ files in terms of an interface, in > tests, or in strings. It's also very suspicious to me that there > seems to be two sets of classes that do the same thing, where one set > is definitely used. > > Can anyone shed more light on this puzzle? I realize I might just be > missing some way they could be used and I'd be happy to find out. > > Patrick Earl > > On Aug 1, 1:33 am, Ayende Rahien <[email protected]> wrote: > > They are used when you set adonet.batch_size to enable batching at the > tcp > > level > > > > On Sun, Aug 1, 2010 at 10:30 AM, Patrick Earl <[email protected]> wrote: > > > Can anyone confirm if the following files are used anymore? > > > > > Impl/IDbCommandSet.cs > > > Impl/DbCommandSet.cs > > > Impl/SqlClientCommandSet.cs > > > Impl/OracleClientCommandSet.cs > > > > > It looks like they've been replaced with batcher implementations in > > > the AdoNet folder. If they are indeed dead code, it would save my > > > time if they went away... mainly the Oracle one so I don't need to > > > port it to work with the client profile. > > > > > Patrick Earl > -- Fabio Maulo
