That is because Read is on the Reader, and you are not doing async stuff there, you are reading from the in memory pool
On Tue, Apr 24, 2012 at 8:38 PM, Diego Mijelshon <[email protected]>wrote: > That would _almost_ work but there are two problems: > - Those methods aren't part of the generic DbCommand: they are implemented > in SqlCommand (not sure about other providers) > - There are no Begin/End methods for operations other than Execute (for > example, Read) > > Diego > > > > On Tue, Apr 24, 2012 at 14:02, Oren Eini (Ayende Rahien) < > [email protected]> wrote: > >> Um, no. >> Task.Factory.FromAsync(cmd.BeginExecuteReader, cmd.EndExecutReader) works >> >> >> On Tue, Apr 24, 2012 at 8:00 PM, Diego Mijelshon >> <[email protected]>wrote: >> >>> Async itself is compiler magic, but the ADO.NET async methods like >>> ExecuteReaderAsync are new in 4.5. >>> Without those, returning tasks from NH is pretty much useless. >>> >>> Diego >>> >>> >>> >>> On Tue, Apr 24, 2012 at 12:54, Darren Kopp <[email protected]> wrote: >>> >>>> To be fair, async is all compiler magic, so the only thing NHibernate >>>> has to do is return Task<T> and consumers could use async / await to their >>>> hearts content. It should be remembered that .net 4.5 is a superset of .net >>>> 4.0, and is separate from the compiler. The question becomes whether >>>> nhibernate will need to use the async / await keywords itself. Also, there >>>> is a project AsyncBridge that allows you to compile using the new compiler >>>> and still target 4.0, so that's an option as well. >>>> >>>> https://nuget.org/packages/AsyncBridge >>>> >>>> >>>> On Tuesday, April 24, 2012 6:34:43 AM UTC-6, Diego Mijelshon wrote: >>>> >>>>> IMO, it _is_ important when it's directly related to the features each >>>>> framework provides. >>>>> I believe async will be quickly become a big deal, so that's something >>>>> to consider. But there's nothing* stopping us from using conditional >>>>> directives to enable 4.5 features. NuGet also supports painless >>>>> multi-framework packages out of the box. >>>>> >>>>> Diego >>>>> >>>>> *: except time/resource constraints, of course >>>>> >>>>> On Tue, Apr 24, 2012 at 06:07, Ramon Smits <ramon.smits> wrote: >>>>> >>>>>> >>>>>> Is it really usefull to discuss which framework to target? >>>>>> >>>>>> I think it is more wise to discuss a roadmap with coming versions and >>>>>> which features those roadmap versions will contain and let that be the >>>>>> input to decide which framework(s) to target. >>>>>> >>>>> >>>>> >>> >> >
