See this Alexander's comment 
<https://github.com/nhibernate/nhibernate-core/pull/1859#issuecomment-436747793>
 
on a PR I have merged without a validation:

> This is quite unfortunate that you are pursuing that path that you’ve 
proposed.

So at least Alexander seems to be opposed to my proposed change. As a 
result, I do not intend to merge more PRs without validation for now, and 
we are back to what I perceived as a near stalled development pace.

The situation of the 5.2 milestone has still evolved since my initial post 
here: only three PRs remains to be done. Some of the previously remaining 
ones were removed from the milestone, some others have been merged. Many 
PRs which were not in the milestone were also merged. So it is nonetheless 
moving, and 5.2 will surely end up released, likely before the end of the 
year.

But still I think we could do better and should allow to merge PRs when no 
one has time to both review them and express grounded concerns about them.

I insist on grounded concern because on some PR, I have got feedback like 
"I still disagree with the change.", without more explanations. There were 
some points raised in previous reviews, but they were addressed either by 
code changes or by explanations on why the change was this way. Such 
disagreement does help neither to fix what could be fix, nor to decide to 
reject the PR, because it does not tell what causes the PR to still be 
considered a bad change. So on such PR I have asked for additional 
explanations, giving more delay by the way, obviously. But so far, no 
answers.

For me, this situation is unhealthy. There are disagreements, on the 
proposition here and on a bunch of PRs, but so far no actual discussions 
for resolving them seem possible. At least for now, they have just not yet 
happened, beyond receiving what looks like straight "no".

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nhibernate-development+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to