If somebody want make a review of our "common-logging" framework + log4net adapter all-in-one the code is here http://nhibernate.svn.sourceforge.net/viewvc/nhibernate/trunk/nhibernate/src/NHibernate/Logging.cs?revision=5132&view=markup
A framework in short. On Mon, Aug 9, 2010 at 1:06 PM, Fabio Maulo <[email protected]> wrote: > You can join to the discussion in dev-list.... but it is something late. > Btw.. > - we have removed a dependency instead substitute > - 90% of NH-users does not have to deploy common.logging and > common.logging.log4net and does not need to configure something else "only > because 3% of users want NLog". > - the "NHibernate.config configuration subsystem" you are talking about > does not exists for logging, it exists for Common.Logging. > If you need an alternative logging-system what you have to do is: > <appSettings> > <add key="nhibernate-logger" value="Your assembly qualified name of > your ILoggerFactory"/> > </appSettings> > that is all. > For 90% that does not have problem with log4net the configuration is: > > Yes... is nothing, they only need to deploy log4net.dll as they are doing > today. > > If you want, you can implements an adapter to use common.logging in NH then > you can make it public and make happy some NH's users. > > > On Mon, Aug 9, 2010 at 12:48 PM, mgernand <[email protected] > > wrote: > >> Hi, >> >> recently I updated the trunk-Version and noticed the introduction of >> a new File "Logging.cs" where the logging Interface is located. Now >> I am a bit surprised that a homegrown logging abstraction is created >> instead of using the Common.Logging 2.0 infrastructure, where alle >> the abstraction work was already done. Now I need to implement a >> custom ILoggerFactory (f.e. NLogLoggerFactory) just because one >> wanted to use the NHibernate.config configuration subsystem? >> >> Whst is the backgound of this - in my opinion - questionable design >> decision? I would have loved to see the integration of Common.Logging >> 2.0 into NHibernate because we are using it all over our projects. >> >> Kind regards, Matthias >> >> -- >> You received this message because you are subscribed to the Google Groups >> "nhusers" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<nhusers%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/nhusers?hl=en. >> >> > > > -- > Fabio Maulo > > -- Fabio Maulo -- You received this message because you are subscribed to the Google Groups "nhusers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/nhusers?hl=en.
