Fabian Deutsch has posted comments on this change. Change subject: Make FQDN validator abide by RFC1035 ......................................................................
Patch Set 1: I agree with you on the point that it's nice to give some differentiated feedback to the user. I'd still suggest to use a regex to validate the length of the sections. The solution looks a bit cumbersome ... If it's valuable for other places too we could even create a validator which takes several validators and validates one after another and spits out the msg assigned to the validator. -- To view, visit http://gerrit.ovirt.org/15583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I747a29c1a15b601bf1eea364b76e56818078e80b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
