Fabian Deutsch has posted comments on this change.
Change subject: Make FQDN validator abide by RFC1035
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File src/ovirt/node/valid.py
Line 279: pattern = ("^(([0-9]\.)?([a-z]|[a-z][a-z0-9\-]*[a-z0-9])\.)*" +
Line 280: "([a-z]|[a-z][a-z0-9\-]*[a-z0-9])$", re.I)
Line 281:
Line 282: def validate(self, value):
Line 283: #FQDNLength()(value)
I believe this should be uncommented
Line 284: return super(FQDN, self).validate(value)
Line 285:
Line 286:
Line 287: class FQDNLength(Validator):
--
To view, visit http://gerrit.ovirt.org/15583
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I747a29c1a15b601bf1eea364b76e56818078e80b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
