hai bo has uploaded a new change for review. Change subject: add debug info and confirm shell is True in function __check_for_problems of process.py ......................................................................
add debug info and confirm shell is True in function __check_for_problems of process.py Change-Id: I32fa0743a781e37799013827310b1895b636d576 Signed-off-by: boh.ricky <[email protected]> --- M src/ovirt/node/utils/process.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/26/19426/1 diff --git a/src/ovirt/node/utils/process.py b/src/ovirt/node/utils/process.py index b6e0cbd..8eb3d65 100644 --- a/src/ovirt/node/utils/process.py +++ b/src/ovirt/node/utils/process.py @@ -22,6 +22,7 @@ import logging import subprocess import sys +import traceback """ Some convenience functions related to processes @@ -44,9 +45,11 @@ def __check_for_problems(args, kwargs): - if ("shell" in kwargs) and (args and type(args[0]) is list): + if ("shell" in kwargs and kwargs["shell"]) and \ + (args and type(args[0]) is list): + LOGGER.debug(traceback.format_exc()) raise RuntimeError("Combining shell=True and a command list does " + - "not work. With shell=True the first argument" + + "not work. With shell=True the first argument " + "must be a string. A list otherwise.") -- To view, visit http://gerrit.ovirt.org/19426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32fa0743a781e37799013827310b1895b636d576 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hai bo <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
