Fabian Deutsch has posted comments on this change.
Change subject: add debug info and confirm shell is True in function
__check_for_problems of process.py
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File src/ovirt/node/utils/process.py
Line 46:
Line 47: def __check_for_problems(args, kwargs):
Line 48: if ("shell" in kwargs and kwargs["shell"]) and \
Line 49: (args and type(args[0]) is list):
Line 50: LOGGER.debug(traceback.format_exc())
Please use
LOGGER.exception("Invaid kwargs combination")
(this will add a stacktrace to the log) instead of importing traceback
Line 51: raise RuntimeError("Combining shell=True and a command list
does " +
Line 52: "not work. With shell=True the first
argument " +
Line 53: "must be a string. A list otherwise.")
Line 54:
--
To view, visit http://gerrit.ovirt.org/19426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32fa0743a781e37799013827310b1895b636d576
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hai bo <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: hadong <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
