Fabian Deutsch has posted comments on this change. Change subject: Get serial console working on Fedora and add TUI configuration ......................................................................
Patch Set 33: Code-Review-1 A couple of things that come to my mind: 1. Is the Bootloader class working with efi and bios? On Fedora and EL? It would be nice if we can somehow add doctests to prevent regressions, as we had many issues with this in the past. 2. In the minimal size (80x24) the button wrapps the label into a second line. This is not nice. Additionally: The button performs a system change, so IMO we shoul dnot show it on the status page. But I couldnÄt find a page where it would fit better. Thoughts on this? -- To view, visit http://gerrit.ovirt.org/17982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id99623830b56b77815196c8b0d153c86d3704f00 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
